16546 define get_absolute_url method in NetBoxModel #17693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
changed the title
bctiemann
reviewed
Oct 8, 2024
bctiemann
approved these changes
Oct 8, 2024
jeremystretch
requested changes
Oct 9, 2024
jeremystretch
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Attempting to run makemigrations fails:
django.core.exceptions.FieldError: 'action_object' cannot be specified for EventRule model form as it is a non-editable field
(Make sure you have the pre-commit hook enabled to catch these errors on commit.)
Edit: My mistake; this was because I still had Django 5.1 installed from a previous PR.
jeremystretch
approved these changes
Oct 10, 2024
bctiemann
pushed a commit
that referenced
this pull request
Oct 16, 2024
* 16546 define get_absolute_url method in NetBoxModel * 16546 define get_absolute_url method in NetBoxModel * 16546 define get_absolute_url method in NetBoxModel * 16546 move get_absolute_url to NetBoxFeatureSet * 16546 fix CircuitTermination * Fix linebreaks --------- Co-authored-by: Jeremy Stretch <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16546