Skip to content

Add a GenericRelation "mac_addresses" to BaseInterface #20486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+6 −0
Closed

Add a GenericRelation "mac_addresses" to BaseInterface #20486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions netbox/dcim/models/device_components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,12 @@ class BaseInterface(models.Model):
null=True,
verbose_name=_('primary MAC address')
)
mac_addresses = GenericRelation(
to='dcim.MACAddress',
content_type_field='assigned_object_type',
object_id_field='assigned_object_id',
related_query_name='interface',
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, doesn't the Interface model already have a mac_addresses generic relation that will just override this?

Same thing for VMInterface. As a matter of fact, I think that overriding this will actually break the expectation that the related query name will be interface for MAC addresses pointing back at VM interfaces.


class Meta:
abstract = True
Expand Down