Fixes #20389: Add FilterSet support to BulkRenameView #20672
+139
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow passing a FilterSet to BulkRenameView for consistent behavior with BulkEditView and BulkDeleteView. Enables the "Select all N matching query" functionality to expand across the full queryset. Updates logic to handle PK lists appropriately when editing all matched objects. Fixes netbox-community#20389
jnovinger
requested review from
a team and
bctiemann
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20389
Summary
Make
BulkRenameViewhonor “Select all N matching query”, aligning behavior withBulkEditView/BulkDeleteView.What changed
BulkRenameViewnow accepts afilterset._all/select_allis posted, the target queryset is derived viafilterset(request.GET, self.get_queryset(request)); otherwise it uses the postedpk[].Impact
No UI or API changes; bulk actions now behave consistently across edit/delete/rename.