-
Notifications
You must be signed in to change notification settings - Fork 66
New Cisco Next-Gen Switches Driver #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Support of Cisco Next-Gen Switches Driver. In my case for C1200-16T-2G - more can be added here. - any 1200 should be supported https://www.cisco.com/c/en/us/products/collateral/switches/catalyst-1200-series-switches/nb-06-cat1200-ser-data-sheet-cte-en.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
Here are my comments.
will work on these changes and will get back to you. thanks :-) |
Hi, can you check? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes.
I still think we need a different name for this driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this driver successfully tested on real devices? Based on CLI object code, I'm not sure how this can work.
/* ========================= DRIVER META ========================= */ | ||
|
||
const Info = { | ||
name: "CiscoNextGenSeries", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cf. my other comment, we need a more specific name for the driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem, true all new switches are next generation hehe.
We can name it Cisco_Catalyst1200-1300.js - for me as long as the driver is supported the name doesn't matter :D
const Info = { | ||
name: "CiscoNextGenSeries", | ||
description: "Cisco Catalyst Next-Gen Series", | ||
author: "DMica(Pizu)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a space
|
||
function snapshot(cli, device, config) { | ||
// Land in enable mode first. | ||
try { cli.macro("enable"); } catch (e) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An error from cli.macro
should be propagated (no catch) to snapshot task it fails there before attempting to issue commands in an unknown context.
username: { | ||
// Matches "User Name:", "Username:", "login:" | ||
prompt: /(User\s*Name|Username|login):\s*$/mi, | ||
response: "%username%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really work? Looks like IA-generated code :-) response
is in pager
context. There should be macros in each mode to transition to the target one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Yes had big parts generated with AI. We needed this driver in order to backup these new devices.
Thanks.
Yes, working. so far no issues. Currently am backing up 6 devices with this driver. |
Support of Cisco Next-Gen Switches Driver.
In my case for C1200-16T-2G - more can be added here. - any 1200 should be supported
https://www.cisco.com/c/en/us/products/collateral/switches/catalyst-1200-series-switches/nb-06-cat1200-ser-data-sheet-cte-en.html
This is related to #361