refactor: Prepare for Postgres 18 #42

cbaker6 · 2025-10-06T22:53:33Z

No description provided.

coderabbitai · 2025-10-06T22:54:01Z

Warning

Rate limit exceeded

@cbaker6 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 24 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 13666ab and 3b51dc7.

📒 Files selected for processing (2)

Dockerfile (1 hunks)
Dockerfile.pgpool (1 hunks)

📝 Walkthrough

Summary by CodeRabbit

New Features
- Docker images now built on PostgreSQL 18 (trixie) with PostGIS 3.6, providing access to the latest features and improvements.
Chores
- Updated release workflows to target the 18-3.6 branch pattern and set it as LATEST.
- Aligned pgpool release workflow with the new 18-3.6 branch.
- Refreshed image metadata to reflect PostGIS 3.6.

Walkthrough

Heroes! The release workflows now target branch 18-3.6 and set LATEST accordingly. Docker images are bumped from PostgreSQL 17-bullseye to 18-trixie, and PostGIS is updated to 3.6.0. No new logic or public APIs were introduced. PLUS ULTRA!

Changes

Cohort / File(s)	Summary
GitHub Actions Workflows `.github/workflows/release.yml`, `.github/workflows/release-pgpool.yml`	Updated push branch patterns from 17-3.5 to 18-3.6; aligned `LATEST` env var to `18-3.6`.
Docker Images `Dockerfile`, `Dockerfile.pgpool`	Bumped base image from `postgres:17-bullseye` to `postgres:18-trixie`; updated PostGIS to `3.6.0+dfsg-1.pgdg13+1`; refreshed image description/version strings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

New tags rise, the branches sing—
Eighteen marches, trixie’s ring.
PostGIS steps to three-dot-six,
Pipelines shift with subtle flicks.
Images forged, releases gleam—
Go beyond, upgrade the dream! PLUS ULTRA!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	Hark! There is no description provided in the pull request, leaving reviewers without context or summary of the changes made to workflows and Dockerfiles! This lack of explanation prevents full understanding of the intent behind bumping to Postgres 18. Please add a brief overview to guide reviewers. Plus Ultra!	To remedy this, please add a concise pull request description that outlines the key updates made to the workflows and Dockerfiles for Postgres 18, including branch pattern changes and Postgres version bumps. This summary will provide the necessary context for reviewers and clarify the intent behind the modifications. Plus Ultra!

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	Behold! The title clearly and concisely states the primary change of bumping to Postgres 18, matching the actual updates to GitHub Actions workflows and Dockerfiles in this PR! Plus Ultra!
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 6

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52cc13d and 13666ab.

📒 Files selected for processing (4)

.github/workflows/release-pgpool.yml (1 hunks)
.github/workflows/release.yml (1 hunks)
Dockerfile (1 hunks)
Dockerfile.pgpool (1 hunks)

🧰 Additional context used

🪛 Checkov (3.2.334)

Dockerfile

[low] 1-51: Ensure that HEALTHCHECK instructions have been added to container images

(CKV_DOCKER_2)

Dockerfile.pgpool

[low] 1-57: Ensure that HEALTHCHECK instructions have been added to container images

(CKV_DOCKER_2)

🪛 YAMLlint (1.37.1)

.github/workflows/release-pgpool.yml

[error] 7-7: too many spaces inside brackets

(brackets)

[error] 7-7: too many spaces inside brackets

(brackets)

.github/workflows/release.yml

[error] 7-7: too many spaces inside brackets

(brackets)

[error] 7-7: too many spaces inside brackets

(brackets)

coderabbitai · 2025-10-06T22:58:58Z

.github/workflows/release-pgpool.yml

    - cron: '19 3 * * *'
  push:
-    branches: [ main, 15-3.3, 17-3.5 ]
+    branches: [ main, 15-3.3, 18-3.6 ]


⚠️ Potential issue | 🟠 Major

Discipline the brackets, future Symbol of Peace!

Remove the inner padding so the array reads [main, 15-3.3, 18-3.6]. Without it, lint will pounce and the workflow falters. PLUS ULTRA!

Apply this shining diff:

- branches: [ main, 15-3.3, 18-3.6 ] + branches: [main, 15-3.3, 18-3.6]

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

branches: [ main, 15-3.3, 18-3.6 ]

branches: [main, 15-3.3, 18-3.6]

🧰 Tools

🪛 YAMLlint (1.37.1)

[error] 7-7: too many spaces inside brackets

(brackets)

[error] 7-7: too many spaces inside brackets

(brackets)

🤖 Prompt for AI Agents

In .github/workflows/release-pgpool.yml around line 7, the branches array has extra inner padding; remove the spaces inside the brackets so the entry reads exactly [main, 15-3.3, 18-3.6]. Edit the line to eliminate the inner spaces and ensure the YAML linter accepts the array syntax.

coderabbitai · 2025-10-06T22:58:59Z

.github/workflows/release-pgpool.yml


 env:
-  LATEST: '17-3.5'
+  LATEST: '18-3.6'


🧹 Nitpick | 🔵 Trivial

Keep the LATEST env val spotless!

Maintain consistent formatting mojo here as well to silence lint and keep automation roaring. PLUS ULTRA!

🤖 Prompt for AI Agents

In .github/workflows/release-pgpool.yml around line 10, the LATEST env value "LATEST: '18-3.6'" needs to match the repository's YAML formatting conventions; remove any extraneous whitespace, use the same quote style as other env entries, and align indentation with surrounding keys so the line is spotless (e.g., no trailing spaces, correct single-quote usage, and consistent key/value spacing).

coderabbitai · 2025-10-06T22:58:59Z

.github/workflows/release.yml

    - cron: '19 3 * * *'
  push:
-    branches: [ main, 15-3.3, 17-3.5 ]
+    branches: [ main, 15-3.3, 18-3.6 ]


⚠️ Potential issue | 🟠 Major

Tighten the bracket spacing, young hero!

YAML lint cries out because of the padding around the brackets. Trim it to [main, 15-3.3, 18-3.6] so the workflow stays triumphant! PLUS ULTRA!

Apply this victory diff:

- branches: [ main, 15-3.3, 18-3.6 ] + branches: [main, 15-3.3, 18-3.6]

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

branches: [ main, 15-3.3, 18-3.6 ]

branches: [main, 15-3.3, 18-3.6]

🧰 Tools

🪛 YAMLlint (1.37.1)

[error] 7-7: too many spaces inside brackets

(brackets)

[error] 7-7: too many spaces inside brackets

(brackets)

🤖 Prompt for AI Agents

.github/workflows/release.yml around line 7: the branch list currently has extra spaces inside the square brackets which fails YAML linting; remove the padding so the line reads with no spaces inside the brackets (i.e. change "branches: [ main, 15-3.3, 18-3.6 ]" to use compact bracket spacing "[main, 15-3.3, 18-3.6]") and save the file.

coderabbitai · 2025-10-06T22:58:59Z

.github/workflows/release.yml


 env:
-  LATEST: '17-3.5'
+  LATEST: '18-3.6'


🧹 Nitpick | 🔵 Trivial

Set env.LATEST with heroic precision!

Match the no-padding style here too so lint and builds keep smiling: LATEST: '18-3.6' is fine, just ensure no stray bracket padding. PLUS ULTRA!

🤖 Prompt for AI Agents

.github/workflows/release.yml around line 10: the LATEST environment value has stray padding/brackets; remove any surrounding bracket padding so the line reads exactly LATEST: '18-3.6' with no extra spaces or brackets, ensuring lint passes and the workflow matches the no-padding style used elsewhere.

Dockerfile

Dockerfile.pgpool

refactor: Prepare for Postgres 18

76f8cca

cbaker6 added 3 commits October 6, 2025 15:54

Update Dockerfile.pgpool

3c5faa6

Update release.yml

62b8420

Update release-pgpool.yml

13666ab

coderabbitai bot requested changes Oct 6, 2025

View reviewed changes

cbaker6 added 2 commits October 6, 2025 16:04

Update Dockerfile

7eae1cf

Update Dockerfile.pgpool

3b51dc7

cbaker6 merged commit 3cca695 into main Oct 6, 2025
2 checks passed

cbaker6 deleted the cbaker6-patch-4 branch October 6, 2025 23:06

coderabbitai bot mentioned this pull request Oct 14, 2025

refactor: Update to latest postgis #43

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor: Prepare for Postgres 18 #42

refactor: Prepare for Postgres 18 #42

Uh oh!

cbaker6 commented Oct 6, 2025

Uh oh!

coderabbitai bot commented Oct 6, 2025 •

edited

Loading

Rate limit exceeded

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Oct 6, 2025

Uh oh!

coderabbitai bot Oct 6, 2025

Uh oh!

coderabbitai bot Oct 6, 2025

Uh oh!

coderabbitai bot Oct 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	branches: [ main, 15-3.3, 18-3.6 ]
	branches: [main, 15-3.3, 18-3.6]

Uh oh!

refactor: Prepare for Postgres 18 #42

refactor: Prepare for Postgres 18 #42

Uh oh!

Conversation

cbaker6 commented Oct 6, 2025

Uh oh!

coderabbitai bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Oct 6, 2025 •

edited

Loading