Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #95 and eliminates a lot of the pitfalls I ran into with that first implementation. However, as discussed in #95, we still cannot do
proxy instanceof Termdirectly. This is because the current implementation ofProxyin Node is not up to specification, nor is the appropriate behavior shimmed byharmony-reflect, as noted in their docs:In the mean time,
Term.isTermchecks forproxy._self instanceof Termwhich is nicer than setting a flag on the object as I was doing before. OnceProxyis fully implemented or shimmed up to spec, we can get rid of this and correctly trap theinstanceofcall.TODO:
Proxyis defined globally (i.e. available in current environment). If not, use existing behavior by modifying__proto__.