ci: run mypy on tests and add initial typing for ssh and tui tests#684
Open
ishan372or wants to merge 4 commits intoneuroinformatics-unit:mainfrom
Open
ci: run mypy on tests and add initial typing for ssh and tui tests#684ishan372or wants to merge 4 commits intoneuroinformatics-unit:mainfrom
ishan372or wants to merge 4 commits intoneuroinformatics-unit:mainfrom
Conversation
JoeZiminski
requested changes
Feb 16, 2026
Member
JoeZiminski
left a comment
There was a problem hiding this comment.
Thanks @ishan372or! please see review, I think instead of using Any we can narrow this to Datashuttle class. If we type hint the output of a function, or a single input, we should probably type the entire function (all inputs and outputs).
259df70 to
ec6d572
Compare
for more information, see https://pre-commit.ci
Member
|
Hi @ishan372or apologies for the delay with this, we are just planning a big release in the next few days. After which this will we can merge this, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Tests were previously excluded from mypy to avoid maintenance burden.
To evaluate feasibility and improve readability where helpful, this PR enables mypy checking for tests and adds an initial, minimal set of type hints. This helps surface real typing issues early and establishes patterns for future incremental improvements.
What does this PR do?
Enables mypy checking for test files.
Adds minimal, targeted type hints to selected SSH test files.
References
Related issue: #532 – Extend type hints to tests
How has this PR been tested?
Ran
pre-commit run mypy --all-fileslocallyIs this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: