-
Notifications
You must be signed in to change notification settings - Fork 10
Add Franka README + fix a few issues with urdf #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds a README for Franka Emika Panda assets, removes two FR3 URDF model files, normalizes Unitree H1 URDF mesh paths to relative ../meshes, and adjusts a visual rotation in the Allegro right-hand URDF. All edits are static asset/markup changes. Changes
Sequence Diagram(s)No sequence diagram provided — changes are static asset/markup edits and file removals, not control-flow or runtime interactions. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| <color rgba=".2 .2 .2 1"/> | ||
| </material> | ||
| <origin rpy="3.1415926518 0 0" xyz="0 0 0"/> | ||
| <origin rpy="0 0 0" xyz="0 0 0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be added in the README when it will be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
franka_emika_panda/fep3.pngis excluded by!**/*.png
📒 Files selected for processing (4)
franka_emika_panda/README.md(1 hunks)unitree_h1/README.md(1 hunks)unitree_h1/urdf/h1_with_hand.urdf(78 hunks)wonik_allegro/urdf/allegro_hand_description_right.urdf(1 hunks)
🔇 Additional comments (4)
unitree_h1/README.md (1)
22-23: LGTM!The documentation accurately describes the mesh path updates made in the URDF file, helping users understand the changes to asset path resolution.
unitree_h1/urdf/h1_with_hand.urdf (1)
25-25: LGTM!All mesh paths have been systematically converted from ROS package paths (
package://h1_description/meshes/) to relative paths (../meshes/). This improves portability and aligns the URDF with the asset folder structure as documented in the README.Also applies to: 62-62, 117-117, 172-172, 227-227, 282-282, 337-337, 392-392, 447-447, 502-502, 557-557, 612-612, 667-667, 722-722, 777-777, 832-832, 887-887, 901-901, 953-953, 964-964, 989-989, 1000-1000, 1044-1044, 1055-1055, 1099-1099, 1110-1110, 1158-1158, 1169-1169, 1217-1217, 1228-1228, 1272-1272, 1283-1283, 1331-1331, 1342-1342, 1386-1386, 1397-1397, 1445-1445, 1456-1456, 1500-1500, 1511-1511, 1559-1559, 1570-1570, 1614-1614, 1625-1625, 1674-1674, 1729-1729, 1784-1784, 1839-1839, 1894-1894, 1908-1908, 1961-1961, 1972-1972, 1997-1997, 2008-2008, 2052-2052, 2063-2063, 2107-2107, 2118-2118, 2166-2166, 2177-2177, 2225-2225, 2236-2236, 2280-2280, 2291-2291, 2339-2339, 2350-2350, 2394-2394, 2405-2405, 2453-2453, 2464-2464, 2508-2508, 2519-2519, 2567-2567, 2578-2578, 2622-2622, 2633-2633, 2668-2668
wonik_allegro/urdf/allegro_hand_description_right.urdf (1)
466-466: Verify mesh orientation in simulation
The<origin>forlink_12.0was changed from a 180° X-rotation to no rotation—ensurelink_12.0_right.STLrenders correctly (e.g., in RViz/Gazebo) or update the mesh if it still appears upside-down.franka_emika_panda/README.md (1)
7-7: Referenced assets verified
fep3.png exists in franka_emika_panda/ and commit d9841cf is valid in frankarobotics/franka_description.
|
I checked that everything is running except for the g1 (waiting for the PR to decrease the number of assets). EDIT: Actually, |
Addressing my own comments Signed-off-by: Philipp Reist <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a commit adressing my comments. Thank you!
Description
Before your PR is "Ready for review"
Summary by CodeRabbit
Documentation
Bug Fixes
Chores