Skip to content

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Nov 6, 2025

Create separate module for each ckeditor translation instead one large bundle with all translations.

Testing:

  • Set the language in nextcloud to not english
  • Open network inspector
  • Click "new message"
  • See an xhr request for a js file containing the translations (on main you won't see that, as there bundle with all translations was fetched before).

main:

image

this branch:

image

Create separate module for each ckeditor translation instead one large
bundle with all translations.

Signed-off-by: Daniel Kesselberg <[email protected]>
@ChristophWurst ChristophWurst merged commit 61a4987 into main Nov 7, 2025
44 checks passed
@ChristophWurst ChristophWurst deleted the one-bundle-per-ckeditor-translation branch November 7, 2025 07:47
@ChristophWurst
Copy link
Member

/backport to stable5.5

@backportbot
Copy link

backportbot bot commented Nov 7, 2025

The backport to stable5.5 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable5.5
git pull origin stable5.5

# Create the new backport branch
git checkout -b backport/12005/stable5.5

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9d8f1f32

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/12005/stable5.5

Error: Failed to check for changes with origin/stable5.5: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants