improving the background of reactions with added contrast

[rapterjet2004]

🚧 TODO

• Ditch this approach, separate the reactions instead.

🖼️ Screenshots

Light	Dark
		Outgoing
		Incoming

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[AndyScherzinger]

@rapterjet2004 how about always having a border on the reaction items? That way we don't waste extra space for margins and paddings?

[AndyScherzinger]

Would also be closer to the the web UI, no?

[mahibi]

@rapterjet2004 how about always having a border on the reaction items? That way we don't waste extra space for margins and paddings?

i agree always having a border on the items will be nicer (instead for the whole LinearLayout).

This is how it looks on web and we should do it similar on clients:

[nimishavijay]

Good call on separating the reactions! Agreed that a border for all together looks a bit off though. We could go for a light background for each reaction, and for the ones the user has reacted with we can do primary colored border with a stronger background :)

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5522.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	99	99
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	10	10
Dodgy code	54	54
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	81	81

[AndyScherzinger]

@rapterjet2004 can you also add the "before" state, to have a better comparison if the color schema is "correct"? Thanks in advance