-
Notifications
You must be signed in to change notification settings - Fork 142
Snapshot for -profile test_assembly_input
#905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nf-core-bot fix linting |
-profile test_assembly_input
|
Ok, after a long time struggling this the stability of this snapshot, it's finally ready for merging. The instability because of:
Regarding BUSCO, I found out that is not able to produce consistently sorted CSV batch files, even when running with a single core... So I decided to left out of the snapshots both |
|
I also updated the |
d4straub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got a few questions, but generally I think the PR is great, and it uncovered already some bugs, thats what its for! :)
|
I added some basic CSV checks for Most of the small fixes I did on this PR originally were ported to other PR for v5.2.0, so this PR has become more simple now. |
prototaxites
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions/comments, but this is looking fine as-is!
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).