Skip to content

Commit 3cd7387

Browse files
author
maxibor
committed
fix: pr review suggestions
1 parent f54b3c0 commit 3cd7387

File tree

4 files changed

+40
-9
lines changed

4 files changed

+40
-9
lines changed

modules/nf-core/ribodetector/main.nf

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,17 @@ process RIBODETECTOR {
1111
tuple val(meta), path(fastq)
1212
val length
1313

14-
1514
output:
1615
tuple val(meta), path("*.nonrna*.fastq.gz"), emit: fastq
17-
tuple val(meta), path("*.log"), emit: log
18-
path "versions.yml" , emit: versions
16+
tuple val(meta), path("*.log") , emit: log
17+
path "versions.yml" , emit: versions
1918

2019
when:
2120
task.ext.when == null || task.ext.when
2221

2322
script:
2423
def args = task.ext.args ?: ''
2524
def prefix = task.ext.prefix ?: "${meta.id}"
26-
2725
ribodetector_bin = task.accelerator ? "ribodetector" : "ribodetector_cpu"
2826
ribodetector_mem = task.accelerator ? "-m $task.memory.toGiga()" : ""
2927
output = meta.single_end ? "${prefix}.nonrna.fastq.gz" : "${prefix}.nonrna.1.fastq.gz ${prefix}.nonrna.2.fastq.gz"
@@ -43,7 +41,6 @@ process RIBODETECTOR {
4341
ribodetector: \$(ribodetector --version | sed 's/ribodetector //g')
4442
END_VERSIONS
4543
"""
46-
4744

4845
stub:
4946
def args = task.ext.args ?: ''
@@ -52,8 +49,8 @@ process RIBODETECTOR {
5249
"""
5350
echo $args
5451
55-
touch ${prefix}.nonrna.1.fastq.gz
56-
touch ${prefix}.nonrna.2.fastq.gz
52+
echo | gzip > ${prefix}.nonrna.1.fastq.gz
53+
echo | gzip > ${prefix}.nonrna.2.fastq.gz
5754
touch ${prefix}.log
5855
5956
cat <<-END_VERSIONS > versions.yml

modules/nf-core/ribodetector/meta.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ keywords:
1515
- genomics
1616
tools:
1717
- "ribodetector":
18-
description: "Accurate and rapid RiboRNA sequences Detector based on deep learning"
18+
description: "Accurate and rapid RiboRNA sequences detector based on deep learning"
1919
homepage: "https://github.com/hzi-bifo/RiboDetector"
2020
documentation: "https://github.com/hzi-bifo/RiboDetector"
2121
tool_dev_url: "https://github.com/hzi-bifo/RiboDetector"

modules/nf-core/ribodetector/tests/main.nf.test

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ nextflow_process {
3030
{ assert process.out.fastq },
3131
{ assert process.out.log },
3232
{ assert path(process.out.log[0][1]).getText().contains("Writing output non-rRNA sequences") },
33+
{ assert snapshot(
34+
path(process.out.versions[0]).yaml
35+
).match() }
3336
)
3437
}
3538

@@ -56,7 +59,10 @@ nextflow_process {
5659

5760
then {
5861
assertAll(
59-
{ assert process.success }
62+
{ assert process.success },
63+
{ assert snapshot(
64+
path(process.out.versions[0]).yaml
65+
).match() }
6066
)
6167
}
6268

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
{
2+
"ribodetector - rnaseq PE input": {
3+
"content": [
4+
{
5+
"RIBODETECTOR": null,
6+
"ribodetector": "0.3.1"
7+
}
8+
],
9+
"meta": {
10+
"nf-test": "0.9.3",
11+
"nextflow": "25.10.0"
12+
},
13+
"timestamp": "2025-10-24T10:37:41.570969"
14+
},
15+
"ribodetector - stub rnaseq PE input": {
16+
"content": [
17+
{
18+
"RIBODETECTOR": null,
19+
"ribodetector": "0.3.1"
20+
}
21+
],
22+
"meta": {
23+
"nf-test": "0.9.3",
24+
"nextflow": "25.10.0"
25+
},
26+
"timestamp": "2025-10-24T10:38:17.647722"
27+
}
28+
}

0 commit comments

Comments
 (0)