-
Notifications
You must be signed in to change notification settings - Fork 218
Use branch-deploy action #3744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Use branch-deploy action #3744
Conversation
This PR is against the
|
56b780f to
fc78026
Compare
fc78026 to
856f12f
Compare
|
@nf-core-bot fix linting |
mirpedrol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvement @kevinbackhouse
Use the Branch Deploy Action to determine who is allowed to trigger these workflows.
pull_request_targetis quite dangerous because it can be triggered by anyone, and it runs with write permissions to the repo, so it could enable an attacker to push new commits to the repo. Similarly, issue comments can be created by anybody. The Branch Deploy Action will only allow people with write permissions to trigger these workflows.PR checklist
CHANGELOG.mdis updateddocsis updated