Skip to content

Conversation

@maxulysse
Copy link
Member

@maxulysse maxulysse commented Nov 4, 2025

Need NXF_VER 25.10.0

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@maxulysse maxulysse marked this pull request as draft November 4, 2025 12:47
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.36%. Comparing base (884c849) to head (0771605).

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maxulysse maxulysse marked this pull request as ready for review November 4, 2025 14:55
include { paramsSummaryMap } from 'plugin/nf-schema'{% endif %}
{%- if multiqc %}
include { paramsSummaryMultiqc } from '../subworkflows/nf-core/utils_nfcore_pipeline'{% endif %}
include { softwareVersionsToYAML } from '../subworkflows/nf-core/utils_nfcore_pipeline'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you're not deleting this in the PR here because it needs to be removed upstream and then updated? Is there a corresponding PR in nf-core/modules?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually my end goal is to totally remove the need for all utils subworklows and use the nf-core-utils plugin instead.
So no plan to remove from the modules yet, I think I will just let it die there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But there should be a separate PR here to actually change the paramsSummaryMultiqc function from the subworkflow to the plugin, and so on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants