feat: include stopped containers for creation/renewal #1211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables toggling the -include-stopped flag in docker-gen with the `INCLUDE_STOPPED` environment variable to enable certificate creation/renewal (and avoiding certificate/symlink removal) for stopped containers.
buchdag
force-pushed
the
feat/stopped-containers
branch
from
cc11a1d to
7758a19
Compare
|
@ftsartek this will be indirectly made possible by an upstream feature on docker-gen See nginx-proxy/docker-gen#623 and nginx-proxy/docker-gen#700, once the later is merged (and a docker-gen version released then used in this project, etc) you'll just have to correctly set the |
|
Ah, that's awesome. Glad to hear it, so this is effectively redundant. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent here is to start a discussion on the viability of enabling certificate renewal for stopped containers; useful when you might want NGINX proxy to serve an 'unavailable' page or similar with a valid certificate.
Seemingly a simple change, though might need some test cases. Would you be open to including this or something similar?