Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ make update-firewall-with-local-ip

### Step 2 - Build and Load Images

Loading the images only applies to a `kind` cluster. If using a cloud provider, you will need to tag and push
your images to a registry that is accessible from that cloud provider.
Loading the images only applies to a `kind` cluster. If using GKE, you will need to tag and push
your images to a registry that is accessible from GKE.

```makefile
make build-images load-images TAG=$(whoami)
Expand All @@ -115,6 +115,8 @@ Or, to build NGF with NGINX Plus enabled (NGINX Plus cert and key must exist in
make build-images-with-plus load-images-with-plus TAG=$(whoami)
```

When building images to run on GKE, you'll need to specify `GOARCH=amd64` in the build command if your local system doesn't default to that architecture.

For the telemetry test, which requires a OTel collector, build an image with the following variables set:

```makefile
Expand Down Expand Up @@ -314,6 +316,8 @@ incremental changes and copy your local changes to the VM to test, you can run
make sync-files-to-vm
```

> Note: if just running longevity tests, skip to the [Longevity section](#longevity-testing).

To set up the GCP environment with the router and VM and then run the tests, run the following command:

```makefile
Expand Down
2 changes: 1 addition & 1 deletion tests/framework/resourcemanager.go
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ func (rm *ResourceManager) WaitForPodsToBeReady(
var podsReady int
for _, pod := range podList.Items {
for _, cond := range pod.Status.Conditions {
if cond.Type == core.PodReady && cond.Status == core.ConditionTrue {
if cond.Type == core.PodReady && (cond.Status == core.ConditionTrue || cond.Reason == "PodCompleted") {
podsReady++
}
}
Expand Down
1 change: 1 addition & 0 deletions tests/suite/system_suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@ func createNGFInstallConfig(cfg setupConfig, extraInstallArgs ...string) framewo
extraInstallArgs = append(
extraInstallArgs,
"--set", "nginxGateway.config.logging.level=debug",
"--set", "nginx.config.logging.agentLevel=debug",
)
}

Expand Down
Loading