Skip to content

Conversation

@sjberman
Copy link
Collaborator

@sjberman sjberman commented Nov 20, 2025

Problem: There has been some confusion around the NGF service that gets deployed at installation time.

Solution: Clarify that this is NOT the NGINX Service.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Problem: There has been some confusion around the NGF service that gets deployed at installation time.

Solution: Clarify that this is NOT the NGINX Service.
@github-actions github-actions bot added chore Pull requests for routine tasks helm-chart Relates to helm chart labels Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (668d4fb) to head (1d346bb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4321      +/-   ##
==========================================
- Coverage   86.08%   86.07%   -0.02%     
==========================================
  Files         132      132              
  Lines       14342    14342              
  Branches       35       35              
==========================================
- Hits        12347    12345       -2     
- Misses       1791     1792       +1     
- Partials      204      205       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman marked this pull request as ready for review November 20, 2025 15:32
@sjberman sjberman requested a review from a team as a code owner November 20, 2025 15:32
@sjberman sjberman merged commit a6d36fc into main Nov 20, 2025
68 checks passed
@sjberman sjberman deleted the chore/helm-note branch November 20, 2025 17:12
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks helm-chart Relates to helm chart

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants