-
Notifications
You must be signed in to change notification settings - Fork 152
Add examples for secure backend traffic guide #4341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4341 +/- ##
==========================================
- Coverage 86.12% 86.11% -0.02%
==========================================
Files 132 132
Lines 14359 14359
Branches 35 35
==========================================
- Hits 12367 12365 -2
- Misses 1787 1789 +2
Partials 205 205 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjee19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to revisit our examples files and see if these are needed since the official document doesn't link or reference any of these files. I think originally it was useful having these manifests since the official doc would apply straight from this repo, but since we have the yaml on the document these aren't used. But approving for now
I think this was decided in the refinement to have these files in the examples folder as well since it was easier for developers to reference. I think it was @shaun-nx who recommended this. Doesn't hurt for us to have the referenced information in github repo. |
decbdfc to
e8b8fb6
Compare
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users need examples for testing examples of secure backend traffic
Solution: Add yaml example files to test secure backend traffic
Testing: Tested that the examples work.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #879
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.