Skip to content

Conversation

@salonichf5
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Users need examples for testing examples of secure backend traffic

Solution: Add yaml example files to test secure backend traffic

Testing: Tested that the examples work.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #879

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@salonichf5 salonichf5 requested a review from a team as a code owner November 25, 2025 23:25
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.11%. Comparing base (c47eee1) to head (2fec59e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4341      +/-   ##
==========================================
- Coverage   86.12%   86.11%   -0.02%     
==========================================
  Files         132      132              
  Lines       14359    14359              
  Branches       35       35              
==========================================
- Hits        12367    12365       -2     
- Misses       1787     1789       +2     
  Partials      205      205              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to revisit our examples files and see if these are needed since the official document doesn't link or reference any of these files. I think originally it was useful having these manifests since the official doc would apply straight from this repo, but since we have the yaml on the document these aren't used. But approving for now

@salonichf5
Copy link
Contributor Author

We might need to revisit our examples files and see if these are needed since the official document doesn't link or reference any of these files. I think originally it was useful having these manifests since the official doc would apply straight from this repo, but since we have the yaml on the document these aren't used. But approving for now

I think this was decided in the refinement to have these files in the examples folder as well since it was easier for developers to reference. I think it was @shaun-nx who recommended this. Doesn't hurt for us to have the referenced information in github repo.

@salonichf5 salonichf5 enabled auto-merge (squash) December 3, 2025 19:24
@salonichf5 salonichf5 merged commit 76a2cea into main Dec 3, 2025
60 of 61 checks passed
@salonichf5 salonichf5 deleted the docs/gateway-mtls branch December 3, 2025 19:53
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Use Case Guide: Setup mTLS to the application from NGF

5 participants