UIImages are now created with a default retina scale#38
Open
mikelovesrobots wants to merge 1 commit intonicklockwood:masterfrom
Open
UIImages are now created with a default retina scale#38mikelovesrobots wants to merge 1 commit intonicklockwood:masterfrom
mikelovesrobots wants to merge 1 commit intonicklockwood:masterfrom
Conversation
|
ipad mini is not yet retina and might get delayed until 2014 |
Author
|
Interesting. Anyway, we found it confusing to work with UIImages from the web at scale 1 in our app. Maybe it should be configurable. |
|
So how can I use this library to load a retina image from a url? The image scale should definitely be configurable now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of iOS7, all devices sold are retina, so it makes sense to transition to loading all the images with the proper scale. This makes it possible when using UIImageViews to use the more interesting view modes like top-left, bottom-right, etc.
If you merge this directly, you'll break the code of people who depended on the old behavior. You might want to make it configurable with the default being 2.0.
[edit] It's not true about all ios7 devices being retina. See comment by bastionhoyer below.