Adding E2E tests #129
Open
Adding E2E tests #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added copy grunt command;
Implemented page object for base test page template; Implemented shared tests for running across dependency matrix;
…g tools are always on the exact same modules; npm formatting updates;
Collaborator
Author
|
@nickperkinslondon I won't merge this tonight. If you do get a chance to review, that would be awesome. Let me know if you have any reservations. I'll probably merge this in the next day or so. I want to come back at it when I'm less tired to make sure I'm not forgetting anything. |
daerogami
force-pushed
the
feature/e2e-tests
branch
from
3c2df59 to
000c331
Compare
|
any reason the update stopped after 1.2 :( |
Collaborator
Author
|
Jumped back to work, then holidays. Will resume in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created initial e2e tests using protractor and will continue to fleshout more tests as time goes on.
This PR also removes generated files. Eventually the current test pages will either only exist generated on the gh-pages branch or a dedicated examples page will take their place.
Recreated this from #128 to rename the branch something more appropriate.
This should not get a published npm release as it does not change anything on the distribution; however, the patch version will be incremented.