fix parsing of atoms #248
Open
fix parsing of atoms #248
+89
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously atoms like category/a-long-name were parsed in such a way that "name" was taken as the version
|
Isn't there a "standard" Gentoo library for this? |
|
Yes, but at some point it was said ebuildtester should be compatible with other distros other than Gentoo |
|
@nicolasbock could you take a look? I think having this bug fixed with help with the user experience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously atoms like category/a-long-name were parsed in such a way that "name" was taken as the version.
This commit also changes the behavior to not parse any version if the atom doesn't starts with "=" sign.
The revision is not needed when it's
r0but it's unconditionally appended when a version is parsed.