Fix wrong collision box scaling of physics props#410
Open
wjxggg wants to merge 2 commits intonillerusr:masterfrom
Open
Fix wrong collision box scaling of physics props#410wjxggg wants to merge 2 commits intonillerusr:masterfrom
wjxggg wants to merge 2 commits intonillerusr:masterfrom
Conversation
Author
|
CBaseAnimating::TestHitboxes always returns true, whether the ray hits or not |
Author
|
And there is a mismatch issue on client side when a prop is scaled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example:

Create a prop_physics entity with SetModelScale(2) then Activate()
Before the fix:

After the fix:

What is wrong:
SetCollisionBounds doesn't require scale information
It reads the scaling information directly from GetModelScale
Which is SetModelScale will do