Don't restart video stream when turning flash off #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the "flickering" when turning the flash off.
|
Hey there, what's the status with this pull request? I just looked for this issue and this looks like a really nice change. Any way I can support you with merging this? |
|
I might also add, that I cannot turn the flash off at all when testing on my OnePlus 9 Pro in Chrome. |
|
if anybody needs this then use my this as dependency "qr-scanner": "git+https://github.com/laszlo1337/qr-scanner.git" |
|
I would also really appreciate it if this could be merged so that there is no need to restart the stream. |
|
nice work on this one. hope this gonna be merged so the flashlight problem will be fixed on the lib. good work everyone 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the "flickering" when turning the flash off.
The comment in the code that I removed indicates that the video stream was explicitly restarted, because a sentence in MDN indicates that this might be necessary.
However, I have tested this with multiple smartphones and found that it is not necessary and that you can toggle off the flash while the stream is active.
Tested with:
(iPhones never have flash available, Apple seems to think it is a good idea to keep their users safe from such useful features.)