lib/modules: replace nixvim builders [v2] #3970
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the legacy "standalone wrapper" `makeNixvimWithModule`, thread the configuration's `config` and `options` to the final package. This allows using such a package as the input to functions like `testNixvim`.
Introduce thin wrappers around the `<configuration>.config.build.package`, option intended to replace the legacy `makeNixvim` and `makeNixvimWithModule` functions.
Introduce thin wrappers around the `<configuration>.config.build.test` option, intended to replace the legacy `mkTestDerivationFromNvim` and `mkTestDerivationFromNixvimModule` functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configandoptionsinbuild.packagebuildNixvimandbuildNixvimWithtestNixvimandtestNixvimWithThis is an alternative to #3964 with a subtly different interface.
This version introduces a
Withvariant alongside each function. TheWithvariant expects the same args asevalNixvim, similar toevalModulesorsubmoduleWith, while the non-Withvariant expects a plain module (similar tosubmodule). The plain module variant also accepts a derivation or configuration.For now, I've kept it simple rather than trying to DRY-up the similar function implementations.