Use harmonia-store-core for a higher-level interface
#22
Conversation
|
The biggest downside to this is that @roberth would sticking the harmonia stuff behind a feature flag that is documented as unstable ameliorate that risk? Or maybe it could be a separate crate? (Ideally still in this repo, though.) |
|
Velocity can cure many ills. I think the right thing to do is give you a commit bit so we can help each other out with maintaining this thing. |
|
I think the first crates.io release should be without this, as insurance of sorts, but we could follow up with one with this right after. Happy to help with that first release too. |
|
Oh and |
Ericson2314
force-pushed
the
use-harmonia-store-core
branch
4 times, most recently
from
4615e86 to
2adfd9a
Compare
|
I've pushed the same commit to |
Ericson2314
force-pushed
the
use-harmonia-store-core
branch
from
2adfd9a to
786fe15
Compare
Creating a crate for bwd-gc highlights the fact that it would be nice to fix 2! The file blocklist is a lost less unmaintainable then the more fine-grained one we had before. Fix nixops4#9
This will come in handy later, when we integrate harmonia. It is a very stable thing to do.
Utilize `harmonia-store-core` for higher level, well-typed, tests. If the JSON format changes, we update that in that library instead. The only purpose of raw JSON would be testing obselete JSON formats versions, which we don't have (that are still supported) yet.
It makes some tests more readable.
Ericson2314
force-pushed
the
use-harmonia-store-core
branch
from
786fe15 to
1fe5dce
Compare
2 participants
The architecture I have in mind is:
This is WIP because it depends on a yet-unmerged branch of harmonia.