Update KVCache type for llama 70B FP8 #2321
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pravg-amd
force-pushed
the
update_70b_ci_irpa
branch
from
03e30d3 to
8d14583
Compare
Coverage report
This PR does not seem to contain any modification to coverable code. |
pravg-amd
changed the title
dan-garvey
approved these changes
Sep 24, 2025
Thanks. Will update the commands here |
IanNod
reviewed
Sep 26, 2025
| --output-config=$OUTPUT_DIR/config_attn.json \ | ||
| --bs-prefill=$PREFILL_BS --bs-decode=$DECODE_BS --attention-kernel sharktank \ | ||
| --use-hf --device-block-count 8043 | ||
| --use-hf --device-block-count 8043 --kv-cache-dtype=$KV_CACHE_DTYPE |
There was a problem hiding this comment.
Why are we using 8043 for device-block-count? Seems like a strange number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.