Update design comments in LlamaHParams #2402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified the state of LlamaHParams and added some light design guidance for future extension.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sogartar
reviewed
Oct 1, 2025
Comment on lines
62
to
64
| See the optional_configs under the get_custom_configs function | ||
| for an example of how to add support for custom Params without | ||
| basing conditionals on a name prefix. |
There was a problem hiding this comment.
I am a bit confused as get_custom_configs
would conditionally populate fields based on the model name prefix.
I think the main point is to have fields in the structure that have general/abstract names such that they survive and can be reused for new models.
There was a problem hiding this comment.
yeah what I was trying to get at is that the optional_keys under that function are agnostic to the name prefix provided. I'll make that clearer
sogartar
approved these changes
Oct 3, 2025
Removed trailing whitespace in docstring of LlamaHParams class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified the state of LlamaHParams and added some light design suggestion for future extension.