Skip to content

update Trie APIs #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

update Trie APIs #2417

wants to merge 6 commits into from

Conversation

lisaliu1
Copy link
Contributor

@lisaliu1 lisaliu1 commented Oct 3, 2025

Trie Cache APIs are aligned with BaseAttentionCache

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

rsuderman
rsuderman requested changes Oct 3, 2025
View reviewed changes
@stbaione
Copy link
Contributor

stbaione commented Oct 3, 2025

Can add a test case for Trie to the presubmit 8b accuracy test

@lisaliu1 lisaliu1 requested a review from rsuderman October 3, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeshanhaque21 zeeshanhaque21 Awaiting requested review from zeeshanhaque21

@stbaione stbaione Awaiting requested review from stbaione

@rsuderman rsuderman Awaiting requested review from rsuderman

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lisaliu1 @stbaione @rsuderman