Skip to content

Correct missing generic type in useReplicantRaw #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Correct missing generic type in useReplicantRaw #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27748af
Correct generic method call
Tempystral Apr 25, 2025
30accd9
Actually make it build
Tempystral Apr 25, 2025
0c88188
Increment version
Tempystral Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@ interface ReactiveReplicant<T> {
loadDefault: () => void
}

export function useReplicant<T>(name: string, namespace: string | undefined, opts: NodeCG.Replicant.Options<T> = {}) {
return useReplicantRaw(name, namespace, opts).reactiveReplicant
type ReplicantOptions<T> = Parameters<typeof nodecg.Replicant<T>>[1];

export function useReplicant<T>(name: string, namespace: string | undefined, opts: ReplicantOptions<T> = {}) {
return useReplicantRaw<T>(name, namespace, opts).reactiveReplicant
}

function useReplicantRaw<T>(name: string, namespace: string | NodeCG.Replicant.Options<T> | undefined, opts: NodeCG.Replicant.Options<T> | undefined) {
function useReplicantRaw<T>(name: string, namespace: string | ReplicantOptions<T> | undefined, opts: ReplicantOptions<T> | undefined) {
if (isRef(name)) {
console.warn(`Tried to create a StaticReplicant using a reactive name (${name.value})`)
throw Error(`Tried to create a StaticReplicant using a reactive name (${name.value})`)
Expand Down Expand Up @@ -84,7 +86,7 @@ function useReplicantRaw<T>(name: string, namespace: string | NodeCG.Replicant.O
}
}

export function useDynamicReplicant<T>(name: Ref<string>, namespace: string, opts: NodeCG.Replicant.Options<T> | undefined) {
export function useDynamicReplicant<T>(name: Ref<string>, namespace: string, opts: ReplicantOptions<T> | undefined) {
if (!isRef(name)) {
console.warn(`Tried to create a DynamicReplicant using a static name (${name})`)
throw Error(`Tried to create a DynamicReplicant using a static name (${name})`)
Expand Down Expand Up @@ -113,10 +115,10 @@ export function useDynamicReplicant<T>(name: Ref<string>, namespace: string, opt


export function useAssetReplicant(name: string, namespace: string) {
const rep = nodecg.Replicant<NodeCG.AssetFile[]>(`assets:${name}`, namespace)
const newVal: Ref<NodeCG.AssetFile[]> = ref([])
const rep = nodecg.Replicant<NodeCG.default.AssetFile[]>(`assets:${name}`, namespace)
const newVal: Ref<NodeCG.default.AssetFile[]> = ref([])

rep.on('change', (newRepVal: NodeCG.AssetFile[] | null | undefined) => {
rep.on('change', (newRepVal: NodeCG.default.AssetFile[] | null | undefined) => {
newVal.value = clone(newRepVal ?? [])
})

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nodecg-vue-composable",
"version": "1.2.1",
"version": "1.2.2",
"description": "A set of Vue composables for interacting more predictably with NodeCG replicants.",
"main": "dist/index.js",
"types": "dist/index.d.ts",
Expand Down Expand Up @@ -28,7 +28,7 @@
}
},
"devDependencies": {
"@nodecg/types": "^2.1.12",
"@nodecg/types": "^2.5.3",
"typescript": "^4.9.4",
"vue": "^3.3.8"
}
Expand Down
Loading