Conversation
77aa4ec to
f6cf994
Compare
8bf831f to
1205b97
Compare
1205b97 to
ff1c9e5
Compare
|
Note to reviewer, only check the top commit since the other one is the security update. I rebased on top of it to validate it would work when the base image (the slim variant) didn't already exist. |
ff1c9e5 to
c3ad7b4
Compare
c3ad7b4 to
67d4cd7
Compare
|
Do we also need an opinion from @tianon? |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
"slim" is already an established convention in official images (with some slight variance for whether it's "FROM slim" or a slimmed image itself), but "core" is not, so I wonder if "core" is already established nomenclature in Node.js communities? Also, I think it's probably worth updating the templating to not copy |
|
We are but painted into a corner because slim already contain package manager so we need a different name. Why not copy the entry point? Do you think it's better to copy from file? |
|
Well, the |
67d4cd7 to
39f78db
Compare
|
Fixed |
There was a problem hiding this comment.
Copilot reviewed 3 out of 16 changed files in this pull request and generated no suggestions.
Files not reviewed (13)
- 18/bookworm-core/Dockerfile: Language not supported
- 18/bullseye-core/Dockerfile: Language not supported
- 18/buster-core/Dockerfile: Language not supported
- 20/bookworm-core/Dockerfile: Language not supported
- 20/bullseye-core/Dockerfile: Language not supported
- 20/buster-core/Dockerfile: Language not supported
- 21/bookworm-core/Dockerfile: Language not supported
- 21/bullseye-core/Dockerfile: Language not supported
- Dockerfile-debian-core.template: Language not supported
- architectures: Language not supported
- functions.sh: Language not supported
- update.sh: Language not supported
- versions.json: Language not supported
|
The big thing for me here is the absence of header files, which accounts to almost 100 MB in savings for multi-stage builds. Package managers are only a few hundred KBs but it also doesn't hurt to omit. Maybe call it |
|
I also have to be the guy to ask for |
Add debian core variant without npm or yarn
Checklist