fix(git-node): improve release tag signature verification #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for non-RSA keys, and for keys with several identities.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
=======================================
Coverage 80.06% 80.06%
=======================================
Files 39 39
Lines 4645 4645
=======================================
Hits 3719 3719
Misses 926 926 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
targos
approved these changes
Sep 1, 2025
There was a problem hiding this comment.
Changes SGTM but I think it will still not match in my case.
The output of the verify-tag command looks like that:
gpg: Signature made Wed Aug 27 23:12:59 2025 CEST
gpg: using RSA key 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600
gpg: Good signature from "Michaël Zasso (Targos) <[email protected]>" [ultimate]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for non-RSA keys, and for keys with several identities.