Skip to content

Conversation

iknoom
Copy link
Contributor

@iknoom iknoom commented Sep 18, 2025

This PR renames ProcessRunner class private fields to follow the snake_case_ naming convention, as specified in doc/contributing/cpp-style-guide.md

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 18, 2025
@iknoom iknoom force-pushed the style-private-fields branch from 0806aef to 0436e0e Compare September 18, 2025 06:23
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.25%. Comparing base (97e55f8) to head (0436e0e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59923      +/-   ##
==========================================
- Coverage   88.27%   88.25%   -0.03%     
==========================================
  Files         703      703              
  Lines      207333   207333              
  Branches    39875    39872       -3     
==========================================
- Hits       183028   182983      -45     
- Misses      16263    16309      +46     
+ Partials     8042     8041       -1     
Files with missing lines Coverage Δ
src/node_task_runner.cc 89.32% <100.00%> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants