Skip to content

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Jan 22, 2026

This also updates ERR_MEMORY_ALLOCATION_FAILED to be a RangeError,
aligning with V8's OutOfMemory error type and ECMAScript's OutOfMemory
error type.

There are still many call sites in crypto, tls and quic need to be reviewed
to properly handle the failed ArrayBuffer BackingStore allocation. This
PR updates call sites not in these modules.

Refs:

isolate, NewRangeError(MessageTemplate::kOutOfMemory,

Refs: https://tc39.es/ecma262/#sec-sharedarraybuffer.prototype.grow
Refs: #61403 (comment)

This also updates `ERR_MEMORY_ALLOCATION_FAILED` to be a RangeError,
aligning with V8's OutOfMemory error type.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 22, 2026
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.86%. Comparing base (c755b01) to head (9326d89).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
src/node_buffer.cc 18.18% 15 Missing and 3 partials ⚠️
src/encoding_binding.cc 40.00% 2 Missing and 1 partial ⚠️
src/node_blob.cc 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61480      +/-   ##
==========================================
+ Coverage   89.85%   89.86%   +0.01%     
==========================================
  Files         665      665              
  Lines      203290   203309      +19     
  Branches    39081    39088       +7     
==========================================
+ Hits       182667   182710      +43     
+ Misses      12977    12945      -32     
- Partials     7646     7654       +8     
Files with missing lines Coverage Δ
src/node_errors.h 84.84% <ø> (ø)
src/encoding_binding.cc 52.12% <40.00%> (-0.62%) ⬇️
src/node_blob.cc 74.93% <40.00%> (-1.11%) ⬇️
src/node_buffer.cc 67.89% <18.18%> (-0.73%) ⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2026
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 25, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2026
@nodejs-github-bot nodejs-github-bot merged commit 3fed9fb into nodejs:main Jan 25, 2026
83 of 84 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3fed9fb

@legendecas legendecas deleted the arraybuffer-allocate branch January 25, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants