repl: fix flaky test-repl-programmatic-history #61614
Open
+27
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flaky test
test/parallel/test-repl-programmatic-history.js.Problem
The test was flaky because the FileHandle for the history file could be garbage collected before being explicitly closed, causing
ERR_INVALID_STATEerrors when the handle was already closed by the GC finalizer.Solution
closeHandle()method toReplHistoryclassREPLServer.close()to wait for the history file handle to be properly closed before completing the close operationVerification
Verified with
python3 tools/test.py --repeat 1000 test/parallel/test-repl-programmatic-history.js- all 1000 runs passed with 0 failures.Refs: nodejs/reliability#1450