[v22.x backport] build: support Python 3.14#61818
Open
MikeMcC399 wants to merge 1 commit intonodejs:v22.x-stagingfrom
Open
[v22.x backport] build: support Python 3.14#61818MikeMcC399 wants to merge 1 commit intonodejs:v22.x-stagingfrom
MikeMcC399 wants to merge 1 commit intonodejs:v22.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: nodejs#59983 Backport-PR-URL: nodejs#61370 Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Refs: nodejs#60874
MikeMcC399
force-pushed
the
backport-59983-to-v22.x
branch
from
f522ca6 to
0cacae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python v3.14 -- October 7th
PR-URL: #59983
Reviewed-By: Marco Ippolito marcoippolito54@gmail.coma
Reviewed-By: Stefan Stojanovic stefan.stojanovic@janeasystems.com
Reviewed-By: Stewart X Addison sxa@redhat.com
Refs: #60874
Refs: #61370
Situation
Node.js 22.x (Maintenance LTS) build fails with Python 3.14.
Python 3.14 is:
py install defaultOn Windows 11 25H2 with prerequisites including Python 3.14.x installed:
git switch v22.x .\vcbuildfails with:
Change
Backports #59983 as modified through the backport PR for v24.x #61370 and commit 1f64d68 in the v24.x branch, resolving merge commits.
The commit message from the backport needs to be modified. The original message "build: test on Python 3.14 release candidate 3" was not entirely accurate, as the commit not only tested on Python 3.14, it also provided support for Python 3.14. Additionally, by the time the PR was merged, Python 3.14 was in GA status, and no longer a release candidate.
The changed commit message is:
Verification
For both Windows and Fedora confirm
Windows
On Windows 11 25H2 manually install prerequisites according to Windows - Option 1: Manual install and using Visual Studio 2022 Build Tools Edition.
Only Python 3.14.x should be shown installed by:
In a PowerShell 7 terminal, execute:
Fedora
On Fedora 43, install prerequisites according to Unix prerequisites:
Execute: