module: run require.resolve through module.registerHooks()#62028
Open
joyeecheung wants to merge 2 commits intonodejs:mainfrom
Open
module: run require.resolve through module.registerHooks()#62028joyeecheung wants to merge 2 commits intonodejs:mainfrom
joyeecheung wants to merge 2 commits intonodejs:mainfrom
Conversation
Previously, require.resolve() called Module._resolveFilename() directly, bypassing any resolve hooks registered via module.registerHooks(). This patch fixes that.
Collaborator
|
Review requested:
|
GeoffreyBooth
approved these changes
Feb 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62028 +/- ##
==========================================
- Coverage 89.73% 89.65% -0.08%
==========================================
Files 676 676
Lines 206069 206285 +216
Branches 39515 39513 -2
==========================================
+ Hits 184915 184951 +36
- Misses 13305 13458 +153
- Partials 7849 7876 +27
🚀 New features to boost your workflow:
|
marco-ippolito
approved these changes
Feb 28, 2026
Member
Author
|
It seems @mcollina @GeoffreyBooth @marco-ippolito Can you take a look at the last commit? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, require.resolve() called Module._resolveFilename() directly, bypassing any resolve hooks registered via module.registerHooks(). This patch fixes that.