Skip to content

build: do not depend on V8 deps on --without-bundled-v8 builds#62033

Merged
aduh95 merged 2 commits intonodejs:mainfrom
aduh95:do-not-build-abseil-twice
Mar 3, 2026
Merged

build: do not depend on V8 deps on --without-bundled-v8 builds#62033
aduh95 merged 2 commits intonodejs:mainfrom
aduh95:do-not-build-abseil-twice

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 27, 2026 •
edited
Loading

The test-shared on ARM macOS goes from having to compile 328 things down to 213 – that should speed up a bit more the test-shared.yml workflow, and reduce the load on the shared binary cache a bit more (which should help with #61436).

AFAICT it's not possible to build Node.js --without-bundled-v8 without providing V8 deps, so this change should not break anything, I've added the dont-land- labels out of precaution.

@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Feb 27, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 27, 2026

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Feb 27, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 28, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71493/

@aduh95 aduh95 requested a review from legendecas March 1, 2026 12:15
@aduh95 aduh95 mentioned this pull request Mar 2, 2026
Open
@aduh95 aduh95 requested a review from richardlau March 2, 2026 17:22
richardlau
richardlau approved these changes Mar 2, 2026
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 2, 2026
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 3, 2026
@aduh95 aduh95 merged commit 48c208f into nodejs:main Mar 3, 2026
36 checks passed
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 3, 2026

Landed in 48c208f

@aduh95 aduh95 deleted the do-not-build-abseil-twice branch March 3, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

@legendecas legendecas legendecas approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95 @nodejs-github-bot @richardlau @legendecas