Skip to content

Conversation

RafaelGSS
Copy link
Member

as titled

@RafaelGSS RafaelGSS requested a review from a team as a code owner December 4, 2024 23:06
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 5, 2024 7:36pm

…es.md

Co-authored-by: Michael Esteban <[email protected]>
Signed-off-by: Rafael Gonzaga <[email protected]>
Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! With Brian's comment

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 4.969s ⏱️

@RafaelGSS RafaelGSS added this pull request to the merge queue Dec 5, 2024
Merged via the queue into nodejs:main with commit 7f3f338 Dec 5, 2024
16 checks passed
@RafaelGSS RafaelGSS deleted the fix-typo-best-practices branch December 5, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants