download: fix nvm instructions

[ljharb]

Description

add "source nvm.sh" to the instructions

Validation

because this is how nvm works

Related Issues

Fixes #7433

Check List

• I have read the Contributing Guidelines and made commit messages that follow the guideline.
• I have run npm run format to ensure the code follows the style guide.
• I have run npm run test to check if all tests are passing.
• I have run npx turbo build to check if the website builds without errors.
• I've covered new added functionality with unit tests if necessary.

[Copilot]

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

• apps/site/snippets/en/download/nvm.bash: Language not supported

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Jan 31, 2025 7:03am

[github-actions]

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 99	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 99	🟢 100	🟢 96	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 96	🟢 92	🔗

[github-actions]

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	88.71% (739/833)	75.94% (240/316)	87.65% (142/162)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
182	0 💤	0 ❌	0 🔥	5.674s ⏱️

[bmuenzenmeyer]

i'd like to fast track this before the weekend - any concerns?

[MikeMcC399]

@ovflowd

I'm now getting a 500 Internal Server Error

https://nodejs.org/en/download
selecting Linux / nvm

Will this sort itself out or does it need intervention?

[ovflowd]

@ljharb you broke the downloads page haha -- Did you test this locally before making a PR?

[ovflowd]

Ive reverted these changes.

[ljharb]

I’m confused how i could have; isn’t this file just text that’s inlined into the page? I indeed didn’t test it locally :-/

I’ll get another PR ready and I’ll test it locally first this time.

[ovflowd]

I’m confused how i could have; isn’t this file just text that’s inlined into the page? I indeed didn’t test it locally :-/

I’ll get another PR ready and I’ll test it locally first this time.

It is because of the ${} -- acorn will handle that as a variable

The whole contents of these bash files get parsed as if they are template strings. So you need to escape the $ I think.

[ljharb]

ahhh ok thanks, that makes sense. I’ll try to add a ci test too that would have caught this.

[bmuenzenmeyer]

I indeed didn’t test it locally :-/

neither did I - lesson learned! more evidence for #7395

[MikeMcC399]

@bmuenzenmeyer

I indeed didn’t test it locally :-/

neither did I - lesson learned! more evidence for #7395

• This is slightly ironic as the reason for my raising nvm download snippet fails on first run #7433 was to give a better setup experience to users of the website testing software Cypress following their Node.js installation instruction links which I had a hand in authoring.

Thanks to all of you who are involved here!