learn: add Asynchronous JS link #7509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivsingh15 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
...site/pages/en/learn/getting-started/how-much-javascript-do-you-need-to-know-to-use-nodejs.md
Outdated
Show resolved
Hide resolved
...site/pages/en/learn/getting-started/how-much-javascript-do-you-need-to-know-to-use-nodejs.md
Show resolved
Hide resolved
...site/pages/en/learn/getting-started/how-much-javascript-do-you-need-to-know-to-use-nodejs.md
Outdated
Show resolved
Hide resolved
Member
|
Hi, @Shivsingh15! Looks like there is an outstanding review, could you please resolve the comments so this PR can move forward? |
Contributor
Author
Hi, I have resolved comments, kindly move the PR forward now. Thanks |
Member
|
Looks like we are almost there! Can you apply the last two suggestions? |
Signed-off-by: Shivsingh15 <[email protected]>
Contributor
Author
|
Hi avivkellar, I resolved from my side. Please Check and if anything is there let me know again. Thanks
…________________________________
From: Aviv Keller ***@***.***>
Sent: 20 March 2025 01:39
To: nodejs/nodejs.org ***@***.***>
Cc: Shivpal Singh ***@***.***>; State change ***@***.***>
Subject: Re: [nodejs/nodejs.org] About Asynchronous JS (PR #7509)
You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
Looks like we are almost there! Can you apply the last two suggestions?
—
Reply to this email directly, view it on GitHub<#7509 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BH3LURKJZILYS5NIDCWH7TD2VHFJJAVCNFSM6AAAAABXX6NP36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZXHE4DENRUGM>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
[avivkeller]avivkeller left a comment (nodejs/nodejs.org#7509)<#7509 (comment)>
Looks like we are almost there! Can you apply the last two suggestions?
—
Reply to this email directly, view it on GitHub<#7509 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BH3LURKJZILYS5NIDCWH7TD2VHFJJAVCNFSM6AAAAABXX6NP36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZXHE4DENRUGM>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
AugustinMauroy
approved these changes
Mar 20, 2025
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Contributor
Unit Test Coverage Report
Unit Test Report
|
avivkeller
approved these changes
Mar 20, 2025
Member
|
Thanks for the contribution, @Shivsingh15! It'll be merged momentarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<!--Please read the Code of Conduct and the Contributing Guidelines before opening a pull request.
-->
Description
Validation
Related Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.