Skip to content

Conversation

@avivkeller
Copy link
Member

Fixes the hamburger visual regression. (I think that's all the regressions!)

Copilot AI review requested due to automatic review settings March 25, 2025 12:23
@vercel
Copy link

vercel bot commented Mar 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 25, 2025 0:23am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix the hamburger visual regression by correcting the styles applied to the sidebar item toggler. The key changes include:

  • Removing unnecessary template literal usage in the nav element.
  • Replacing the previous className (which included the "peer" class and sidebarItemToggler) with a new style (sidebarItemTogglerLabel) for the Label component.
Comments suppressed due to low confidence (2)

packages/ui-components/Containers/NavBar/index.tsx:58

  • Ensure that removing the 'peer' class (which was present in the previous version) does not impact any CSS rules or behaviors that relied on it. Confirm that the new 'sidebarItemTogglerLabel' style encapsulates all necessary styling for the toggler.
className={style.sidebarItemTogglerLabel}

packages/ui-components/Containers/NavBar/index.tsx:51

  • [nitpick] The change from a template literal to a direct reference simplifies the code; however, verify that no dynamic behavior was expected from the original string interpolation.
<nav className={style.container}>

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 91 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
84.74% (500/590) 76.03% (165/217) 87.09% (108/124)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.712s ⏱️
@nodejs/website 157 0 💤 0 ❌ 0 🔥 6.235s ⏱️

@avivkeller avivkeller added the fast-track Fast Tracking PRs label Mar 25, 2025
@avivkeller avivkeller enabled auto-merge March 25, 2025 12:33
@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Mar 25, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 25, 2025
@avivkeller avivkeller added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 82a8d18 Mar 25, 2025
29 checks passed
@avivkeller avivkeller deleted the fix/ui-regressions-2 branch March 25, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants