-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: apply correct styles to sidebarItemToggler
#7572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to fix the hamburger visual regression by correcting the styles applied to the sidebar item toggler. The key changes include:
- Removing unnecessary template literal usage in the nav element.
- Replacing the previous className (which included the "peer" class and sidebarItemToggler) with a new style (sidebarItemTogglerLabel) for the Label component.
Comments suppressed due to low confidence (2)
packages/ui-components/Containers/NavBar/index.tsx:58
- Ensure that removing the 'peer' class (which was present in the previous version) does not impact any CSS rules or behaviors that relied on it. Confirm that the new 'sidebarItemTogglerLabel' style encapsulates all necessary styling for the toggler.
className={style.sidebarItemTogglerLabel}
packages/ui-components/Containers/NavBar/index.tsx:51
- [nitpick] The change from a template literal to a direct reference simplifies the code; however, verify that no dynamic behavior was expected from the original string interpolation.
<nav className={style.container}>
|
Lighthouse Results
|
Fixes the hamburger visual regression. (I think that's all the regressions!)