Skip to content

Conversation

@avivkeller
Copy link
Member

Description

This PR removes the incomplete sentence in the fetch learn guide, and instead references the "Specification Compliance" section of the official Undici documentation.

Related Issues

Fixes #7568

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings April 16, 2025 20:27
@avivkeller avivkeller requested a review from a team as a code owner April 16, 2025 20:27
@vercel
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 17, 2025 9:02pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.63%. Comparing base (c0d6b17) to head (8309f49).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7654      +/-   ##
==========================================
+ Coverage   74.61%   74.63%   +0.02%     
==========================================
  Files          96       96              
  Lines        7685     7685              
  Branches      192      192              
==========================================
+ Hits         5734     5736       +2     
+ Misses       1949     1947       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller added this pull request to the merge queue Apr 18, 2025
Merged via the queue into main with commit b3d7077 Apr 18, 2025
17 checks passed
@avivkeller avivkeller deleted the fix/fetch branch April 18, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incomplete sentence in fetch docs

7 participants