Skip to content

Conversation

@avivkeller
Copy link
Member

As it currently stands, this workflow is reviewing the main branch for vulnerabilities whenever a PR is opened. Rather, it should be reviewing the PRs. Running on pull_request instead will cause this to execute in the context of the PR, rather than the context of the base branch.

Ref: https://github.com/actions/dependency-review-action#installation-standard

Copilot AI review requested due to automatic review settings April 16, 2025 20:48
@avivkeller avivkeller requested a review from a team as a code owner April 16, 2025 20:48
@vercel
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 17, 2025 7:48pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.github/workflows/dependency-review.yml:12

  • Changing the trigger event to 'pull_request' correctly ensures that the workflow runs in the context of the PR, not the base branch. Verify that the branch filter 'main' aligns with the intended target.
pull_request:

@avivkeller
Copy link
Member Author

You can see a comparison of the executions:

On pull_request_target:

On pull_request:

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, doesn't look like this'd need any secrets etc. that'd nessecitate it being pull_request_target (the alternative would be to pass the correct ref into the checkout)

@ovflowd
Copy link
Member

ovflowd commented Apr 17, 2025

I'm fine fast-tracking this due to security concerns.

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 17, 2025
@ovflowd ovflowd enabled auto-merge April 17, 2025 19:22
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 93 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (c0d6b17) to head (1624311).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7655      +/-   ##
==========================================
- Coverage   74.61%   74.58%   -0.03%     
==========================================
  Files          96       96              
  Lines        7685     7685              
  Branches      192      192              
==========================================
- Hits         5734     5732       -2     
- Misses       1949     1951       +2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Apr 17, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 17, 2025
@ovflowd ovflowd added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit de28b0f Apr 17, 2025
18 checks passed
@ovflowd ovflowd deleted the fix/dep-review branch April 17, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants