-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(dep-review): incorrect trigger #7655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/dependency-review.yml:12
- Changing the trigger event to 'pull_request' correctly ensures that the workflow runs in the context of the PR, not the base branch. Verify that the branch filter 'main' aligns with the intended target.
pull_request:
|
You can see a comparison of the executions: On On |
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine, doesn't look like this'd need any secrets etc. that'd nessecitate it being pull_request_target (the alternative would be to pass the correct ref into the checkout)
|
I'm fine fast-tracking this due to security concerns. |
|
Lighthouse Results
|
Signed-off-by: Aviv Keller <[email protected]>
b5f4b15 to
1624311
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7655 +/- ##
==========================================
- Coverage 74.61% 74.58% -0.03%
==========================================
Files 96 96
Lines 7685 7685
Branches 192 192
==========================================
- Hits 5734 5732 -2
- Misses 1949 1951 +2
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As it currently stands, this workflow is reviewing the main branch for vulnerabilities whenever a PR is opened. Rather, it should be reviewing the PRs. Running on
pull_requestinstead will cause this to execute in the context of the PR, rather than the context of the base branch.Ref: https://github.com/actions/dependency-review-action#installation-standard