fix(ci): label check

[avivkeller]

@nodejs/web-infra This is being fast-tracked.

The PR I just merged contained a minor issue: the action would trigger on any label, not just our special one.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Apr 17, 2025 6:36pm

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.github/workflows/chromatic.yml:42

• GitHub pull_request_target events typically provide multiple labels as an array rather than a single label object. Consider verifying if 'github.event.label' exists as expected or updating the check to iterate over the labels array to ensure that the intended label is present.

github.event.label.name == 'github_actions:pull-request' &&

[github-actions]

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 99	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟠 86	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 96	🟢 92	🔗

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.57%. Comparing base (162cd26) to head (b94b65f).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7659      +/-   ##
==========================================
+ Coverage   74.54%   74.57%   +0.02%     
==========================================
  Files          96       96              
  Lines        7673     7673              
  Branches      194      194              
==========================================
+ Hits         5720     5722       +2     
+ Misses       1951     1949       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[avivkeller]

Hey, Codecov works :-)

[MattIPv4]

merge_group is a trigger here, but the if is never going to let that happen?

It might be useful to have an explainer block for the triggers here, similar to what the old workflow this was pulled out of had?

[avivkeller]

I, for the most part, took this chunk directly out of that workflow, so some parts I missed, like removing the merge_group or verifying the label

[avivkeller]

Thanks for the quick approval, @MattIPv4! I know I merged this pretty quickly, but I wanted to avoid cluttering our deployments with unnecessary Storybooks. I was also concerned that a mislabel could trigger a potentially unsafe job. While executing that job still required deliberate maintainer action, it increased the risk of unintentionally launching a Chromatic deployment without proper review.

[ovflowd]

Thanks for the quick approval, @MattIPv4! I know I merged this pretty quickly, but I wanted to avoid cluttering our deployments with unnecessary Storybooks. I was also concerned that a mislabel could trigger a potentially unsafe job. While executing that job still required deliberate maintainer action, it increased the risk of unintentionally launching a Chromatic deployment without proper review.

Fine by me.