-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat(infra): adopt pnpm
#7662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(infra): adopt pnpm
#7662
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
running full ci just for fun |
FWIW because this changes the gh workflow run lint-and-tests.yml --ref pnpmBefore merging, just remove the trigger. |
|
Assuming that CI passes, all reviews, tasks, and failures have been addressed |
|
Required checks, despite being listed as pending, pass on manual run:
Review dependencies fails because of GHSA-f7f6-9jq7-3rqj. AFAICT this isn't an issue for us, since all the content we are supplying has been manually reviewed (unlike a public forum, where the data is arbitrary) |
|
@nodejs/web-infra This cannot land via the merge queue. When you feel comfortable landing this (not now, but when your ready), you will need bypass the branch protection rules. |
Co-authored-by: Matt Cowley <[email protected]> Signed-off-by: Aviv Keller <[email protected]>
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we can ovoid pnpm and use node that would be nice
According to the vote, we are to use pnpm when possible. |
|
If there are no other objections, could someone with Bypass Rules permissions merge this on Monday? (I'm -1 on merging before the weekend, lest something bad happen) |
I'm feeling daring today :P |
|
(Amazing work y'all, btw) |
+1 |
next.config.js,next-intl, i18n work — commitpnpm build— import errors resolved, packages cleaned uppnpm buildwhen installed with--prodpnpm devpnpm devwhen installed with--prodpnpm test- subpath import work neededpnpm test:cipnpm lintpnpm lint:fixpnpm prettierpnpm prettier:fixpnpm formatpnpm storybookpnpm storybook:buildpnpm check-typespnpm scripts:release-postnpm use casesTasks from Vote
pnpmto README and docspackage-lock.jsonto.gitignorepnpmin CIpnpm-lock.yamlin CIdevEnginesandpackageManagertopackage.json