feat(test): replace cloudflare open-next build test with playwright tests #7782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the GitHub workflow that verifies the Cloudflare open-next build with a new workflow that runs Playwright tests to validate the build.
- Updated Playwright configuration to support dynamic web server setup via environment variables.
- Replaced the Cloudflare worker build test with a Playwright test workflow that includes caching, browser installation, and report upload.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/site/playwright.config.ts | Updated Playwright configuration including conditional web server launch and dynamic baseURL setup. |
| .github/workflows/playwright-cloudflare-open-next.yml | Replaced the Cloudflare build job with a Playwright testing job along with concurrency and caching improvements. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7782 +/- ##
=======================================
Coverage 75.35% 75.36%
=======================================
Files 96 96
Lines 7861 7862 +1
Branches 192 192
=======================================
+ Hits 5924 5925 +1
Misses 1936 1936
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
avivkeller
reviewed
May 27, 2025
avivkeller
reviewed
May 27, 2025
avivkeller
reviewed
May 27, 2025
…right tests simplify logic as suggested
…right tests update forgotten env variable name in playwright.yml
…right tests still accept VERCEL_PREVIEW_URL to make PR go green
avivkeller
approved these changes
May 27, 2025
…right tests remove VERCEL_PREVIEW_URL
ovflowd
reviewed
May 29, 2025
…right tests avoid running a script taken from process.env
…right tests add new getWebServerConfig function instead of using a ternary
ovflowd
reviewed
May 30, 2025
ovflowd
approved these changes
May 31, 2025
flakey5
approved these changes
May 31, 2025
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the github workflow checking that the Cloudflare open-next build process works on PRs and pushes to main with a workflow that runs and checks the open-next build using playwright (built on top of the changes introduced in #7749)
Validation
I've validated this change by pushing this onto my fork's main branch and you can see the workflow working as expected there by checking the action runs (example)
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.