fix(ci): disable all locale export #8440
Conversation
Signed-off-by: Aviv Keller <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Pull request overview
This PR disables the export of all locales in the CI build process due to space constraints. The change removes the conditional logic that previously exported all locales only on push events while restricting pull_request events to the default locale only.
Key Changes:
- Removed the
NEXT_PUBLIC_STATIC_EXPORT_LOCALEenvironment variable that conditionally enabled all-locale exports - Added a TODO comment noting that exporting all locales consumes too much space
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8440 +/- ##
==========================================
- Coverage 73.65% 73.64% -0.02%
==========================================
Files 108 108
Lines 9193 9193
Branches 312 312
==========================================
- Hits 6771 6770 -1
- Misses 2420 2421 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Aviv Keller <[email protected]>
MattIPv4
left a comment
MattIPv4
left a comment
There was a problem hiding this comment.
Let's make sure to file a follow-up issue to discuss getting a larger runner for this
|
This should be fast-trackable as a small fix :) |
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
No description provided.