feat(`util.is()`): introduce #119

AugustinMauroy · 2025-07-24T15:02:57Z

Description

Close #116

recipes/util-is/README.md

avivkeller · 2025-07-24T15:47:43Z

@AugustinMauroy Can you check the original implementations and make sure these match them?

If they do, can you make that clear?

AugustinMauroy · 2025-07-24T20:15:37Z

@avivkeller & @ljharb I just applied what the docs said. So I will not change it for now.

Here docs ref

recipes/util-is/src/workflow.ts

AugustinMauroy · 2025-07-25T08:14:42Z

I'm sorry @ljharb but If you think there are better way to handle that please first update node api doc and then we will update this codemod

ljharb · 2025-07-25T15:32:36Z

For the opinion ones, fine, but one of them is a bug and is just broken. It shouldn't matter what's in the docs, but it matters what code does.

AugustinMauroy · 2025-07-25T20:27:59Z

For the opinion ones, fine, but one of them is a bug and is just broken. It shouldn't matter what's in the docs, but it matters what code does.

I'm annoyed because I'm caught between two stools. On the one hand, I agree with you. On the other, I want to follow the documentation strictly so that the org node is consistent.

ljharb · 2025-07-26T06:48:25Z

That seems like an arbitrary and counterproductive constraint to me. The docs aren’t the source of truth, they need to reflect the actual source of truth, the code.

AugustinMauroy · 2025-07-29T20:07:59Z

cc @ljharb synced with the pr

ljharb · 2025-07-29T20:10:28Z

LGTM, thanks!

recipes/util-is/src/workflow.ts

utils/src/ast-grep/import-statement.ts

recipes/util-is/workflow.yml

recipes/util-is/codemod.yml

Co-authored-by: Bruno Rodrigues <[email protected]>

recipes/util-is/package.json

JakobJingleheimer

Looking good!

Aside from a few small things / nets, I think it's just missing support for dynamic imports?

recipes/util-is/README.md

recipes/util-is/codemod.yml

recipes/util-is/src/workflow.ts

recipes/util-is/tests/expected/file-1.js

recipes/util-is/workflow.yml

AugustinMauroy · 2025-08-20T09:42:29Z

I think it's just missing support for dynamic imports?

Any of our codemod support that so if we want to support that do it in aside pr that create utility + update codemod

JakobJingleheimer · 2025-08-21T07:32:04Z

Any of our codemod support that so if we want to support that do it in aside pr that create utility + update codemod

I think all of our migrations must support that in order to claim the deprecation is handled, which I believe is the intention. If it's best to create a shared util to do it, let's do that right away.

I thought you had previously said all of our current ones do handle this (and your message here also says they do, but I'm guessing from the rest that they actually don't?).

AugustinMauroy · 2025-08-21T09:04:26Z

think all of our migrations must support that in order to claim the deprecation is handled, which I believe is the intention. If it's best to create a shared util to do it, let's do that right away.

I just realized that we have utility for that but I was never used

I thought you had previously said all of our current ones do handle this (and your message here also says they do, but I'm guessing from the rest that they actually don't?).

It's a misunderstanding there are any of our codemod that support that

Co-Authored-By: Jacob Smith <[email protected]>

recipes/util-is/README.md

JakobJingleheimer

Did dynamic import support get added? I think that was my only previous request.

JakobJingleheimer · 2025-09-16T08:22:03Z

recipes/util-is/src/workflow.ts

@@ -69,7 +69,7 @@ const replacements = new Map<string, (arg: string) => string>([
 * 5. util.isError() → value instanceof Error
 * 6. util.isFunction() → typeof value === 'function'
 * 7. util.isNull() → value === null
- * 8. util.isNullOrUndefined() → value == null
+ * 8. util.isNullOrUndefined() → value === null || value === undefined


very nit since it's a comment:

Suggested change

* 8. util.isNullOrUndefined() → value === null || value === undefined

* 8. util.isNullOrUndefined() → value == null

https://github.com/nodejs/node/blob/main/doc/api/deprecations.md#dep0051-utilisnullorundefined

Yes, I understand :)

null == null // true undefined == null // true false == null // false 0 == null // false '' == null // false

The difference is in document.all, I believe, which doesn't apply to node but would if someone cargoculted the info into a browser.

so what should I do ?

JakobJingleheimer · 2025-09-16T08:22:23Z

recipes/util-is/tests/expected/file-1.js

@@ -20,7 +20,7 @@ if (typeof someValue === 'function') {
 if (someValue === null) {
 	console.log('someValue is null');
 }
-if (someValue == null) {
+if (someValue === null || someValue === undefined) {


nit:

Suggested change

if (someValue === null || someValue === undefined) {

if (someValue == null) {

AugustinMauroy requested a review from a team July 24, 2025 15:03

AugustinMauroy changed the title ~~Feat(util.is())~~ feat(util.is()): introduce Jul 24, 2025

ljharb reviewed Jul 24, 2025

View reviewed changes

recipes/util-is/README.md Outdated Show resolved Hide resolved

recipes/util-is/README.md Outdated Show resolved Hide resolved

recipes/util-is/README.md Outdated Show resolved Hide resolved

recipes/util-is/README.md Outdated Show resolved Hide resolved

avivkeller approved these changes Jul 24, 2025

View reviewed changes

ljharb reviewed Jul 24, 2025

View reviewed changes

recipes/util-is/src/workflow.ts Outdated Show resolved Hide resolved

recipes/util-is/src/workflow.ts Outdated Show resolved Hide resolved

recipes/util-is/src/workflow.ts Outdated Show resolved Hide resolved

AugustinMauroy mentioned this pull request Jul 29, 2025

doc: update deprecation guide for util.is**() nodejs/node#59269

Merged

AugustinMauroy force-pushed the feat(`util.is()`) branch 2 times, most recently from 76b6fb5 to 1f71b3e Compare July 29, 2025 20:07

AugustinMauroy requested a review from a team July 29, 2025 21:15

brunocroh reviewed Jul 29, 2025

View reviewed changes

recipes/util-is/src/workflow.ts Outdated Show resolved Hide resolved

utils/src/ast-grep/import-statement.ts Outdated Show resolved Hide resolved

brunocroh reviewed Jul 30, 2025

View reviewed changes

recipes/util-is/workflow.yml Outdated Show resolved Hide resolved

recipes/util-is/codemod.yml Outdated Show resolved Hide resolved

AugustinMauroy mentioned this pull request Jul 30, 2025

feat: handle crypto.createCredentials() depreciation #123

Open

brunocroh approved these changes Aug 8, 2025

View reviewed changes

AugustinMauroy and others added 6 commits August 12, 2025 10:49

scaffold codemod

21c272e

feat(util.is**()): introduce

22c84fe

WIP

4a5d5f0

improve

4ca8c17

apply code suggestion

5f7369a

Apply suggestions from code review

b52adfd

Co-authored-by: Bruno Rodrigues <[email protected]>

AugustinMauroy force-pushed the feat(`util.is()`) branch from 7d65dc8 to b52adfd Compare August 12, 2025 08:49

feat(util.is()): improve

afbc8fd

avivkeller approved these changes Aug 12, 2025

View reviewed changes

brunocroh approved these changes Aug 19, 2025

View reviewed changes

recipes/util-is/package.json Outdated Show resolved Hide resolved

JakobJingleheimer reviewed Aug 20, 2025

View reviewed changes

AugustinMauroy and others added 3 commits August 21, 2025 11:12

Merge branch 'main' into feat(util.is())

7169e83

update

e9df057

update from feedback

f679a55

Co-Authored-By: Jacob Smith <[email protected]>

JakobJingleheimer reviewed Aug 31, 2025

View reviewed changes

recipes/util-is/README.md Outdated Show resolved Hide resolved

recipes/util-is/README.md Outdated Show resolved Hide resolved

recipes/util-is/README.md Outdated Show resolved Hide resolved

update

09a7d8d

brunocroh approved these changes Aug 31, 2025

View reviewed changes

JakobJingleheimer reviewed Sep 16, 2025

View reviewed changes

JakobJingleheimer added blocked:upstream Depends on another PR or external change/fix missing functionality Required use-case missing and removed blocked:upstream Depends on another PR or external change/fix labels Sep 16, 2025

	* 8. util.isNullOrUndefined() → value === null \|\| value === undefined
	* 8. util.isNullOrUndefined() → value == null

	if (someValue === null \|\| someValue === undefined) {
	if (someValue == null) {

Uh oh!

feat(util.is()): introduce #119

Are you sure you want to change the base?

feat(util.is()): introduce #119

Uh oh!

Conversation

AugustinMauroy commented Jul 24, 2025

Description

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avivkeller commented Jul 24, 2025

Uh oh!

AugustinMauroy commented Jul 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AugustinMauroy commented Jul 25, 2025

Uh oh!

ljharb commented Jul 25, 2025

Uh oh!

AugustinMauroy commented Jul 25, 2025

Uh oh!

ljharb commented Jul 26, 2025

Uh oh!

AugustinMauroy commented Jul 29, 2025

Uh oh!

ljharb commented Jul 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AugustinMauroy commented Aug 20, 2025

Uh oh!

JakobJingleheimer commented Aug 21, 2025

Uh oh!

AugustinMauroy commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

ljharb Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer Sep 16, 2025

Choose a reason for hiding this comment

feat(`util.is()`): introduce #119

feat(`util.is()`): introduce #119

AugustinMauroy commented Aug 21, 2025 •

edited

Loading