Skip to content

Fix NpgsqlOptionsExtension losing ParameterizedCollectionMode between clones #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 3 commits into from
Mar 31, 2026
+16 −0
Merged

Fix NpgsqlOptionsExtension losing ParameterizedCollectionMode between clones #3796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce8718c
Initial plan
Copilot Mar 30, 2026
19a93da
Fix NpgsqlOptionsExtension losing ParameterizedCollectionMode between…
Copilot Mar 30, 2026
b81cad0
Apply suggestion from @roji
roji Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/EFCore.PG/Infrastructure/Internal/NpgsqlOptionsExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ public NpgsqlOptionsExtension(NpgsqlOptionsExtension copyFrom)
DataSourceBuilderAction = copyFrom.DataSourceBuilderAction;
AdminDatabase = copyFrom.AdminDatabase;
_postgresVersion = copyFrom._postgresVersion;
_parameterizedCollectionMode = copyFrom._parameterizedCollectionMode;
UseRedshift = copyFrom.UseRedshift;
_userRangeDefinitions = [..copyFrom._userRangeDefinitions];
_enumDefinitions = [..copyFrom._enumDefinitions];
Expand Down
15 changes: 15 additions & 0 deletions test/EFCore.PG.Tests/NpgsqlDbContextOptionsExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,21 @@ public void Can_add_extension_with_command_timeout()
Assert.Equal(30, extension.CommandTimeout);
}

[ConditionalFact]
public void ParameterizedCollectionMode_is_preserved_after_clone()
{
var optionsBuilder = new DbContextOptionsBuilder();
optionsBuilder.UseNpgsql("Database=Crunchie", b =>
{
b.UseParameterizedCollectionMode(ParameterTranslationMode.MultipleParameters);
b.UseRelationalNulls();
});

var extension = optionsBuilder.Options.Extensions.OfType<NpgsqlOptionsExtension>().Single();

Assert.Equal(ParameterTranslationMode.MultipleParameters, extension.ParameterizedCollectionMode);
}

[ConditionalFact]
public void Can_add_extension_with_connection_string()
{
Expand Down
Loading