Skip to content

fix: change paragraph to small tag for legal copy#1950

Merged
graphieros merged 1 commit intonpmx-dev:mainfrom
BradEstey:patch-1
Mar 5, 2026
Merged

fix: change paragraph to small tag for legal copy#1950
graphieros merged 1 commit intonpmx-dev:mainfrom
BradEstey:patch-1

Conversation

@BradEstey
Copy link
Contributor

🔗 Linked issue

None 🫣

🧭 Context

Use <small> to semantically represent legal disclaimers or copyright notices.

📚 Description

Just a small (get it?) change to show my support. 😅

@vercel
Copy link

vercel bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 5, 2026 3:02pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 5, 2026 3:02pm
npmx-lunaria Ignored Ignored Mar 5, 2026 3:02pm

Request Review

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 87b6da13-4662-44cd-b1a7-fb6104f441d5

📥 Commits

Reviewing files that changed from the base of the PR and between 5530873 and da9d1df.

📒 Files selected for processing (1)
  • app/components/AppFooter.vue

📝 Walkthrough

Walkthrough

The pull request modifies the AppFooter.vue component by changing the HTML semantic element used for the disclaimer container. The element is changed from a paragraph (<p>) tag to a <small> tag, whilst maintaining the identical CSS classes and content structure. The functionality and data flow remain unchanged. This is a minimal semantic HTML adjustment affecting only the element type, with no modifications to the component's public API or exported entities.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the rationale for replacing a paragraph element with a small tag for semantic HTML representation of legal disclaimers.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@graphieros graphieros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@graphieros graphieros added this pull request to the merge queue Mar 5, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 5, 2026
@graphieros graphieros added this pull request to the merge queue Mar 5, 2026
Merged via the queue into npmx-dev:main with commit ee3ffaa Mar 5, 2026
20 checks passed
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Thanks for your first contribution, @BradEstey! 👏

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants